remove iter.Pull and iter.Pull2 usages
#10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whole idea is that you can range over functions themselves without additional wrapper types. You only need `iter.Pull` and `iter.Pull2` when you plan to store the iterable between iterations (stateful iterator). Otherwise, you are just losing performance for context switches. Benchmarks on my Mac M1 before applying changes: ``` goos: darwin goarch: arm64 pkg: github.com/gomoni/it BenchmarkRangeFilter BenchmarkRangeFilter-10 489 2362737 ns/op BenchmarkItFilterSlice BenchmarkItFilterSlice-10 16 67850156 ns/op BenchmarkItFilterFor BenchmarkItFilterFor-10 25 47034218 ns/op PASS ``` After the changes: ``` goos: darwin goarch: arm64 pkg: github.com/gomoni/it BenchmarkRangeFilter BenchmarkRangeFilter-10 474 2359972 ns/op BenchmarkItFilterSlice BenchmarkItFilterSlice-10 274 4270057 ns/op BenchmarkItFilterFor BenchmarkItFilterFor-10 393 3044019 ns/op PASS ``` The loss of speed it still there, but now it's around 1.5 to 2 times.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whole idea is that you can range over functions themselves without additional wrapper types. You only need
iter.Pullanditer.Pull2when you plan to store the iterable between iterations (stateful iterator). Otherwise, you are just losing performance for context switches.Benchmarks on my Mac M1 before applying changes:
After the changes:
The loss of speed it still there, but now it's around 1.5 to 2 times.