feat(sdk): add trader v3 with gomu order book #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongwee
approved these changes
Jul 28, 2022
| } | ||
|
|
||
| function makeAnyAsset(asset: Asset): AnyAsset { | ||
| if (asset.type === "ERC721") { |
There was a problem hiding this comment.
Curios - why the special treatment specifically for 721?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a trader v3 marketplace (mostly copied from trader v4) that uses the gomu order book.
Right now, the order book is a simple CRUD backend that is not monitoring events from the chain. For simplicity, we could post status updates to the order book after confirmation from ethers after cancelling and taking (but isn't done so in this PR).
What is more important is the query pattern required to fetch orders. Right now I only have a very simple query params of maker address, maker asset, taker address, taker asset. We'll probably need an active, cancelled, expired status, which I can add next. Let me know what else is required.