[WIP] feat: return response object when making order #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongwee
force-pushed
the
yongwee/order_pack
branch
2 times, most recently
from
6aeb378
to
86a8068
Compare
leeyikjiun
approved these changes
Jun 3, 2022
yongwee
force-pushed
the
yongwee/order_pack
branch
2 times, most recently
from
0c6232b
to
423d333
Compare
- do not throw when error is encountered; this is so in the event where one order goes through and one fails, we can handle both
yongwee
force-pushed
the
yongwee/order_pack
branch
from
423d333
to
1bdc329
Compare
kainanaina
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@leeyikjiun @kainanaina
Let me know if the approach is going in the right direction
Also of note:
Opensea seems to throw with Error objects all the time (which is good), but traderXYZ seems to throw a mix of error object + JSON responses
May need to do some sanitization from the TraderXYZ marketplace SDK side