Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic swap sdk (inside Gomu sdk) that makes and takes orders, without orderbook #7

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Basic swap sdk (inside Gomu sdk) that makes and takes orders, without orderbook #7

wants to merge 3 commits into from

Conversation

kainanaina
Copy link
Contributor

  1. Add swapSdk to Gomu sdk.
  2. Add 2 new methods to Gomu sdk - makeSwapOrder (returns signed order) and takeSwapOrder (takes signed orders).
  3. Both new methods are currently not very useful without orderbook, so this PR can be frozen for a while.
  4. Also v3 SDK got method for cancelling orders, but I'm not sure what is the purpose of it, since people who manage order book can do a better job, without any gass fees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeyikjiun leeyikjiun Awaiting requested review from leeyikjiun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kainanaina