Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong noise usage #11

Closed
olivieryuyu opened this issue Oct 3, 2014 · 12 comments
Closed

wrong noise usage #11

olivieryuyu opened this issue Oct 3, 2014 · 12 comments

Comments

@olivieryuyu
Copy link

premier manager 64: the balloon in menu displayed wrong noise
Pro Mahjong Kiwame 64: in menu
Ms. Pac-Man Maze Madness during intro
F1 Pole Position Menu
mario Golf in background during intro

@olivieryuyu olivieryuyu changed the title premier manager 64: the balloon in menu displayed wrong noise wrong noise usage Oct 19, 2014
@olivieryuyu
Copy link
Author

@olivieryuyu
Copy link
Author

seems the change in mario gold alpha compare made the noise issue solved in some game?

@olivieryuyu
Copy link
Author

KI also

ki

@gonetz
Copy link
Owner

gonetz commented Mar 1, 2015

Please re-check on current version. For example, noise in KI is not wrong - software LLE plugin works the same.

@olivieryuyu
Copy link
Author

tested on real N64, i cannot see noise in KI.

Pro Mahjong Kiwame 64: the "push start" has no noise displayed at title screen

Overhaul it is better indeed

@gonetz
Copy link
Owner

gonetz commented Mar 1, 2015

tested on real N64, i cannot see noise in KI.

Hmm, noise looks natural here - only area above the cloud is noised.
But you're right. Video from the real N64 shows that part of the logo above the cloud is not visible:
https://www.youtube.com/watch?v=Yzh1liSii0M
Logo works correct if noise emulation is disabled. I guess that noise dithering is really used here, but noised area has zero alpha. My noise implementation adds random alpha to that area and make it visible. LLE software works the same. Original hardware does not dither zero values. Need to prove it.

@gonetz
Copy link
Owner

gonetz commented Mar 28, 2015

Hopefully fixed.
Need carefully testing for all noise based effects. It was hard to make them all working right.

@olivieryuyu
Copy link
Author

tested with Pro Mahjong Kiwame 64 and even the wrong usage of noise in this game is gone.
KI fixed as well.

Great job :)

gonetz added a commit that referenced this issue May 13, 2015
@olivieryuyu
Copy link
Author

Angrylion explained me that the noise was normal for KI. he even did some tests for this.

Hence i guess there is something odd

@olivieryuyu olivieryuyu reopened this Sep 13, 2015
@AmbientMalice
Copy link
Contributor

There's also the fact enabling noise breaks Perfect Dark. #518

@gonetz
Copy link
Owner

gonetz commented Sep 19, 2015

@AmbientMalice #518 is not related to this issue.

@olivieryuyu do you suggest to revert that fix? You know, that on real hardware the part of logo above the cloud is not visible. You may see it on LCD monitors or on videos recorded from video capture devices. Thus, it can't be explained by fading luminophor of CRT TV.

@olivieryuyu
Copy link
Author

i will forward you the concerns of angrylion here by email. Not sure either what is correct here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants