Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NBA Live 99 messed up textures #1826

Closed
Tasosgemah opened this issue May 30, 2018 · 6 comments
Closed

NBA Live 99 messed up textures #1826

Tasosgemah opened this issue May 30, 2018 · 6 comments

Comments

@Tasosgemah
Copy link

There is something wrong with the player's skin textures

untitled

@gonetz
Copy link
Owner

gonetz commented May 30, 2018

Regression? When it worked correct last time?

@Tasosgemah
Copy link
Author

@gonetz
Not sure what WIP version was the last good one. It's still broken in the Public Release 3 but it looks fine in Public Release 2.

Also, in PJ64 it needs to uncheck "32-bit engine", else the polygons become corrupted. Not sure if this is an emulator thing or a plugin.

@LegendOfDragoon
Copy link

Also, in PJ64 it needs to uncheck "32-bit engine"

Problem is, users don't contribute to the official RDB settings. Most games run fine with 32-bit engine enabled, but some games do require it (Sports games, Rare, Factor 5, Boss Game Studio, etc). I never tested this game, but I'll take your word for it and assume it's required for this game. I could do a pull request and improve the settings for a few games.

@Tasosgemah
Copy link
Author

Tasosgemah commented Jun 4, 2018

@LegendOfDragoon

Can i ask, what's the point of this 32bit engine option? AFAIK it was a speed up setting maybe? But that was back to the Pentium 3-4 days so is it important to be enabled by default in most games these days?

Theoretically, if it was disabled in all games none would have a problem? Or there are games that absolutely need this option to work?

@LegendOfDragoon
Copy link

AFAIK it was a speed up setting maybe?

Yes, it is only for speed up, but it is a good one.

But that was back to the Pentium 3-4 days so is it important to be enabled by default in most games these days?

He actually first implemented it in PJ64 2.x, so the option isn't that old. Same argument could be made for using async mode by default instead of sync mode, or using HLE instead of LLE.

Considering most of the work has been done and all we have to do is tweak settings for a few games, it's worth keeping imo.

gonetz added a commit that referenced this issue Sep 5, 2018
Writes to TMEM protected by masking TMEM write address, so it is not necessary anymore.
Rearrange the code a bit.

Fixed NBA Live 99 messed up textures #1826
@avdland
Copy link
Contributor

avdland commented Sep 5, 2018

nba_live_99-000
fixed, great work gonetz! 👍

@gonetz gonetz closed this as completed Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants