Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use graphics backend in GLideNHQ #1768

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Use graphics backend in GLideNHQ #1768

merged 1 commit into from
Mar 27, 2018

Conversation

loganmc10
Copy link
Contributor

This is a fix for #1765

GLideNHQ still references OpenGL directly. This is just a refactor to have it go through the graphics backend.

I had to change the switch statements to if/else because the compiler would not accept case u32(graphics::internalcolorFormat::RGBA8): type statements.

@loganmc10
Copy link
Contributor Author

loganmc10 commented Mar 26, 2018

The only other real change I made was:

InternalColorFormatParam RGB8(GL_RGB8);

so internalcolorFormat::RGB8 now equals GL_RGB8 instead of GL_RGB, the internal color formats should be sized.

I cannot figure out why the AppVeyor build is failing, it says:

..\..\src\Graphics\OpenGLContext\opengl_Parameters.cpp(7): warning C4003: not enough actual parameters for macro 'RGB' [C:\projects\gliden64\projects\msvc2015\GLideN64.vcxproj]

..\..\src\Graphics\OpenGLContext\opengl_Parameters.cpp(7): error C2143: syntax error: missing ')' before '(' [C:\projects\gliden64\projects\msvc2015\GLideN64.vcxproj]

It compiles in Linux, I'm not sure what the issue is.

@loganmc10
Copy link
Contributor Author

Ok I figured it out, Windows has a built-in macro called RGB. I renamed the colorFormat macro to RED_GREEN_BLUE. I tried doing an #undef RGB at the top of the header file but it didn't seem to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants