Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement in-memory variant of Qfile #59

Merged
merged 2 commits into from
May 28, 2021
Merged

Conversation

EtienneBruines
Copy link
Contributor

As part of unifying the interface, I also made sure the "Add"
function of Qfile actually does what it describes in the doc:
creating the value if the tag does not yet exist.

Close is not part of the Qfiler interface, because (1) only the
Qfile itself needs it, and (2) because the SendQfile function
does not call it: it is only used by the SendQfileFromDisk,
function which does not use the Qfiler interface but the Qfile
directly.

Updated tests accordingly.

As part of unifying the interface, I also made sure the "Add"
function of Qfile actually does what it describes in the doc:
creating the value if the tag does not yet exist.

Close is not part of the Qfiler interface, because (1) only the
Qfile itself needs it, and (2) because the SendQfile function
does not call it: it is only used by the SendQfileFromDisk,
function which does not use the Qfiler interface but the Qfile
directly.

Updated tests accordingly.
@denzs denzs merged commit 95946b4 into gonicus:master May 28, 2021
@denzs
Copy link
Member

denzs commented May 28, 2021

Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants