This repository has been archived by the owner on Nov 25, 2018. It is now read-only.
fd: handle correctly repeated origins in Jacobian #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not at a computer at the moment to review, but could you check that this situation is correct for the other functions (gradient, etc) |
|
Fixes #35 |
vladimir-ch
force-pushed
the
jacobian-multiple-origin
branch
from
c1ea907
to
0efc47f
Compare
|
LGTM |
|
I checked and |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to me that if we do this, the unlikely situation of repeated origins is handled correctly and we don't need to add any new checks and documentation.