Image creation #59
Closed
Image creation #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xists, error if not
…xists, error if not
|
Can we leave this until its dependency is done? |
|
Yes for sure
…On Wed, Sep 18, 2019 at 8:16 PM Dan Kortschak ***@***.***> wrote:
Can we leave this until its dependency is done?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#59?email_source=notifications&email_token=AEOWLFTPTOOPAE65NSXV2UTQKLAHFA5CNFSM4IXQ7LTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7B2BLQ#issuecomment-532914350>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEOWLFWTOKNQFFY43PCNEFTQKLAHFANCNFSM4IXQ7LTA>
.
|
golangcibot
reviewed
Sep 19, 2019
h5g_group_test.go
Outdated
| defer os.Remove("img.jpg") | ||
| defer imgfile.Close() | ||
|
|
||
| jpeg.Encode(imgfile, imgRead, nil) |
There was a problem hiding this comment.
Error return value of jpeg.Encode is not checked (from errcheck)
There was a problem hiding this comment.
Just added and pushed
|
Please wait until the dependency is accepted and merged. |
zyc-sudo
force-pushed
the
imageCreation
branch
from
1ca363c
to
a77d793
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look.
This one actually is depends on the previous PR of the
I decided to seperated it to keep this as features of the image operation