Skip to content
This repository was archived by the owner on Nov 24, 2018. It is now read-only.

Commit 038df32

Browse files
committed
lapack/native: remove unnecessary parameters of Dlasq5
1 parent 6068cf1 commit 038df32

File tree

3 files changed

+8
-621
lines changed

3 files changed

+8
-621
lines changed

native/dlasq3.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ func (impl Implementation) Dlasq3(i0, n0 int, z []float64, pp int, dmin, sigma,
9898
// Call dqds until dmin > 0.
9999
loop:
100100
for {
101-
i0, n0, pp, tau, sigma, dmin, dmin1, dmin2, dn, dn1, dn2 = impl.Dlasq5(i0, n0, z, pp, tau, sigma, dmin, dmin1, dmin2, dn, dn1, dn2)
101+
i0, n0, pp, tau, sigma, dmin, dmin1, dmin2, dn, dn1, dn2 = impl.Dlasq5(i0, n0, z, pp, tau, sigma)
102102

103103
nDiv += n0 - i0 + 2
104104
iter++

native/dlasq5.go

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,7 @@ import "math"
1010
// i0 and n0 are zero-indexed.
1111
//
1212
// Dlasq5 is an internal routine. It is exported for testing purposes.
13-
func (impl Implementation) Dlasq5(i0, n0 int, z []float64, pp int, tau, sigma, dmin, dmin1, dmin2, dn, dnm1, dnm2 float64) (i0Out, n0Out, ppOut int, tauOut, sigmaOut, dminOut, dmin1Out, dmin2Out, dnOut, dnm1Out, dnm2Out float64) {
14-
// TODO(btracey): It seems like outputs listed in the reference implementation
15-
// are actually true outputs, unlike other functions where the value is
16-
// preserved through the call. When a more full test suite exists, make them
17-
// true outputs if it turns out the value does not need to be preserved through
18-
// the call.
19-
13+
func (impl Implementation) Dlasq5(i0, n0 int, z []float64, pp int, tau, sigma float64) (i0Out, n0Out, ppOut int, tauOut, sigmaOut, dmin, dmin1, dmin2, dn, dnm1, dnm2 float64) {
2014
// The lapack function has inputs for ieee and eps, but Go requires ieee so
2115
// these are unnecessary.
2216
if n0-i0-1 <= 0 {

0 commit comments

Comments
 (0)