lapack: add stricter size checks in Dlantr #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a way to add the Draft state post hoc? These new panics will of course trigger until gonum/gonum#1207 is merged and the module info updated to pick it up. |
|
I had hoped that this was possible a while back, but don't think there is. |
kortschak
reviewed
Dec 20, 2019
|
We should probably start versioning this repo formally. Should we start with v0.6.0 and track the minor version of gonum/gonum? |
For certain input (documented as invalid but not checked) DLANTR in Fortran LAPACK causes out-of-bound writes. Even though this has been fixed in the Reference and will soon be in OpenBLAS, other implementations may take longer. Therefore this commit adds checks for the "invalid" matrix sizes because it's better to panic with a message rather than cause memory corruption.
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
=========================================
- Coverage 30.23% 30.2% -0.03%
=========================================
Files 4 4
Lines 6414 6420 +6
=========================================
Hits 1939 1939
- Misses 4039 4045 +6
Partials 436 436
Continue to review full report at Codecov.
|
kortschak
previously approved these changes
Dec 28, 2019
vladimir-ch
force-pushed
the
lapack/dlantr-size-checks
branch
from
7084584
to
3a59b26
Compare
|
I've extended the commit message. Can you re-approve? |
kortschak
approved these changes
Dec 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look.