This repository has been archived by the owner on Nov 23, 2018. It is now read-only.
Modify bisection so it only requests the gradient when appropriate #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #127 |
| // in that direction. | ||
| if g > 0 { | ||
| b.maxStep = b.currStep | ||
| b.maxF = f |
There was a problem hiding this comment.
We use f even though the last operation was GradEvaluation. We should either document that Linesearchers must receive the previous function value after requesting GradEvaluation or (probably better) we should store f after FuncEvaluation and then we don't have to assume anything.
|
LGTM once the commented line is removed |
|
Btw, I like how our recent changes gradually reduce the runtime of the tests. This change helps especially CG, its search directions are badly scaled and the linesearch takes a couple of iterations (7-10 on average last time I checked, of course depending on the problem). |
btracey
added a commit
that referenced
this pull request
Oct 2, 2015
Modify bisection so it only requests the gradient when appropriate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.