Skip to content

Commit 1eb59dc

Browse files
committed
internal/cmpimg: use bytes.Reader.Size
As Gonum only support Go >= 1.6, we can use bytes.Reader.Size, that was introduced after Go-1.4.
1 parent 2cfc072 commit 1eb59dc

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

internal/cmpimg/cmpimg.go

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,20 +45,14 @@ func Equal(typ string, raw1, raw2 []byte) (bool, error) {
4545
return true, nil
4646

4747
case "pdf":
48-
// TODO(sbinet): bytes.Reader.Size was introduced only after go-1.4
49-
// use that if/when we drop go-1.4 bwd compat.
5048
r1 := bytes.NewReader(raw1)
51-
sz1 := int64(len(raw1))
52-
pdf1, err := pdf.NewReader(r1, sz1)
49+
pdf1, err := pdf.NewReader(r1, r1.Size())
5350
if err != nil {
5451
return false, err
5552
}
5653

57-
// TODO(sbinet): bytes.Reader.Size was introduced only after go-1.4
58-
// use that if/when we drop go-1.4 bwd compat.
5954
r2 := bytes.NewReader(raw2)
60-
sz2 := int64(len(raw2))
61-
pdf2, err := pdf.NewReader(r2, sz2)
55+
pdf2, err := pdf.NewReader(r2, r2.Size())
6256
if err != nil {
6357
return false, err
6458
}

0 commit comments

Comments
 (0)