Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: bump to git.sr.ht/~sbinet/gg@v0.3.1 #741

Merged
merged 3 commits into from
Jan 19, 2022
Merged

Conversation

sbinet
Copy link
Member

@sbinet sbinet commented Jan 18, 2022

Please take a look.

Fixes #687.
Fixes #645.
Fixes #559.

@sbinet sbinet requested a review from kortschak January 18, 2022 11:42
@kortschak
Copy link
Member

Looks like some module clean up needs to happen.

@sbinet
Copy link
Member Author

sbinet commented Jan 18, 2022

it's probably coming from x/image itself.

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022

Codecov Report

Merging #741 (9e9193f) into master (08671db) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #741      +/-   ##
==========================================
+ Coverage   73.22%   73.23%   +0.01%     
==========================================
  Files          56       58       +2     
  Lines        5154     5366     +212     
==========================================
+ Hits         3774     3930     +156     
- Misses       1196     1243      +47     
- Partials      184      193       +9     
Impacted Files Coverage Δ
vg/vgimg/vgimg.go 50.00% <ø> (+2.90%) ⬆️
vg/vggio/context.go 100.00% <0.00%> (ø)
vg/vggio/vggio.go 67.37% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08671db...9e9193f. Read the comment docs.

@sbinet
Copy link
Member Author

sbinet commented Jan 18, 2022

PTAL

@kortschak
Copy link
Member

Do we have a test case for the bug that this fixes?

@sbinet
Copy link
Member Author

sbinet commented Jan 18, 2022

in ~sbinet/gg, yes:

but you're right that one of the referenced gonum/plot issues could be turned into a proper test.
I'll do that tomorrow (Paris' time)

@kortschak
Copy link
Member

Thanks. In that commit, I still don't understand the need for the slackness in the pixel distance; I was unable to get any of the test suite of gg to fail by changing it to dx+dy != 0 and the commit that introduced it made no comment about why it was chosen.

Signed-off-by: Sebastien Binet <binet@cern.ch>
Fixes gonum#687.
Fixes gonum#645.
Fixes gonum#559.

Signed-off-by: Sebastien Binet <binet@cern.ch>
Signed-off-by: Sebastien Binet <binet@cern.ch>
@sbinet
Copy link
Member Author

sbinet commented Jan 19, 2022

PTAL.

as for your #741 (comment), I haven't put too much intelligence in ~sbinet/gg yet (?), aiming for just "same codebase, same bugs, save for the one at hand".

there's probably some amount of low hanging fruits to address in this new repo
(e.g. reducing the API surface, reusing go-text stuff, ...)

@sbinet sbinet merged commit f70d910 into gonum:master Jan 19, 2022
@sbinet sbinet deleted the issue-687 branch January 19, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants