-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: bump to git.sr.ht/~sbinet/gg@v0.3.1 #741
Conversation
Looks like some module clean up needs to happen. |
it's probably coming from |
Codecov Report
@@ Coverage Diff @@
## master #741 +/- ##
==========================================
+ Coverage 73.22% 73.23% +0.01%
==========================================
Files 56 58 +2
Lines 5154 5366 +212
==========================================
+ Hits 3774 3930 +156
- Misses 1196 1243 +47
- Partials 184 193 +9
Continue to review full report at Codecov.
|
PTAL |
Do we have a test case for the bug that this fixes? |
in but you're right that one of the referenced |
Thanks. In that commit, I still don't understand the need for the slackness in the pixel distance; I was unable to get any of the test suite of gg to fail by changing it to |
Signed-off-by: Sebastien Binet <binet@cern.ch>
Signed-off-by: Sebastien Binet <binet@cern.ch>
PTAL. as for your #741 (comment), I haven't put too much intelligence in there's probably some amount of low hanging fruits to address in this new repo |
Please take a look.
Fixes #687.
Fixes #645.
Fixes #559.