imports: add handling of whitelists #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kortschak
force-pushed
the
whitelist
branch
2 times, most recently
from
90cd082
to
bc7ea0e
Compare
sbinet
reviewed
Jul 27, 2018
cmd/check-imports/main.go
Outdated
| @@ -2,13 +2,17 @@ | |||
| // Use of this source code is governed by a BSD-style | |||
| // license that can be found in the LICENSE file. | |||
|
|
|||
| // Command check-imports inspects a source tree for blacklisted imports. | |||
| // Command check-imports inspects a source tree for imports satisfying a | |||
| // whitelist/blacklist scheme. If a whitelist in included, packages from | |||
imports/imports.go
Outdated
| } | ||
|
|
||
| // str returns a slice of patterns matching the standard library. | ||
| func std() ([]string, error) { |
There was a problem hiding this comment.
alternatively, this could be pre-generated with a //go:generate go list std directive.
(one for each Go version we support, "of course.")
There was a problem hiding this comment.
I think this is a lower maintenance burden.
|
I am ok with automatically adding |
sbinet
reviewed
Jul 27, 2018
imports/imports.go
Outdated
| } | ||
|
|
||
| // str returns a slice of patterns matching the standard library. | ||
| func std() ([]string, error) { |
imports/imports.go
Outdated
| return append(list, pkgs...), nil | ||
| } | ||
|
|
||
| // str returns a slice of patterns matching the standard library. |
That doesn't allow quite the same set of operations. If you have |
|
PTAL |
sbinet
approved these changes
Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds whitelist/blacklist handling. I'm not sure about the approach to std; at the moment it adds std to the whitelist if there is one. The two other options are to have pseudo-packages to specify inclusion or exclusion of std ("std" and "-std" respectively). I think requiring "std" to be added for whitelisting is probably too onerous, so that just leaves a "-std" for cases where std should be removed from the whitelist,... or just leaving it how it is. Thoughts?
Please take a look.
Closes #4.