Use lists by default like msgspec, update to latest msgspec and msgpack releases
#300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lul I'll get to it 🏄🏼 |
goodboy
changed the title
msgspecmsgspec, update to latest msgspec API
guilledk
approved these changes
Feb 9, 2022
guilledk
approved these changes
Feb 14, 2022
goodboy
force-pushed
the
msgpack_lists_by_default
branch
from
2859797
to
17e195a
Compare
goodboy
changed the title
msgspec, update to latest msgspec APImsgspec, update to latest msgspec and msgpack releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per jcrist/msgspec#30 (comment) there's not much of a benefit in our use case (IPC messaging often with dynamic lists) and we can always (and are planning to) support native structs eventually anyway.
The further benefit is that we can assume
msgspecandmsgpackwill be uniform in the array format after decode.Relates to #196 and #294.