Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lists by default like msgspec, update to latest msgspec and msgpack releases #300

Merged
merged 9 commits into from
Feb 15, 2022

Conversation

goodboy
Copy link
Owner

@goodboy goodboy commented Feb 9, 2022

As per jcrist/msgspec#30 (comment) there's not much of a benefit in our use case (IPC messaging often with dynamic lists) and we can always (and are planning to) support native structs eventually anyway.

The further benefit is that we can assume msgspec and msgpack will be uniform in the array format after decode.

Relates to #196 and #294.

@goodboy goodboy added IPC and transport messaging messaging patterns and protocols labels Feb 9, 2022
@goodboy
Copy link
Owner Author

goodboy commented Feb 9, 2022

Lul msgpec version update broke everything.

I'll get to it 🏄🏼

@goodboy goodboy changed the title Use lists by default like msgspec Use lists by default like msgspec, update to latest msgspec API Feb 9, 2022
@goodboy goodboy changed the title Use lists by default like msgspec, update to latest msgspec API Use lists by default like msgspec, update to latest msgspec and msgpack releases Feb 14, 2022
@goodboy goodboy merged commit 6e5590d into master Feb 15, 2022
@goodboy goodboy deleted the msgpack_lists_by_default branch February 15, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IPC and transport messaging messaging patterns and protocols
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants