Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proto registry Filter offset and limit fields have the wrong type. #124

Closed
sakarias88 opened this issue Oct 7, 2020 · 0 comments
Closed

Proto registry Filter offset and limit fields have the wrong type. #124

sakarias88 opened this issue Oct 7, 2020 · 0 comments

Comments

@sakarias88
Copy link
Member

sakarias88 commented Oct 7, 2020 •
edited by simonrainerson
Loading

message Filters {
...
uint32 offset = 3;
uint32 limit = 4;
...
}

They should be uint64 since we use it as an usize.

  • Just change the fields in firm/protocols/functions/functions.proto.
  • Make sure the updated type compiles on all projects that depend on the proto type.
@simonrainerson simonrainerson changed the title Proto ListRequest offset and limit fields have the wrong type. Proto registry Filter offset and limit fields have the wrong type. Nov 10, 2020
sakarias88 added a commit that referenced this issue Apr 29, 2022
@sakarias88
⚡Change proto size to match usize
d0754da 
Random fix fixing #124.
@sakarias88 sakarias88 mentioned this issue Apr 29, 2022
Merged
sakarias88 added a commit that referenced this issue May 13, 2022
@sakarias88
⚡Change proto size to match usize
6e47868 
Random fix fixing #124.
sakarias88 added a commit that referenced this issue Jun 10, 2022
@sakarias88
⚡Change proto size to match usize
8948f2b 
Random fix fixing #124.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sakarias88 @simonrainerson