Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSDK-121 change linter to ruff #201

Merged
3 commits merged into from
Jan 16, 2023
Merged

PSDK-121 change linter to ruff #201

3 commits merged into from
Jan 16, 2023

Conversation

hkad98
Copy link
Contributor

@hkad98 hkad98 commented Jan 13, 2023

No description provided.

@ghost
Copy link

ghost commented Jan 13, 2023

Build succeeded (check pipeline).

@hkad98 hkad98 removed the request for review from lupko January 13, 2023 12:27
@jaceksan jaceksan added the merge label Jan 16, 2023
@ghost ghost removed the merge label Jan 16, 2023
@ghost
Copy link

ghost commented Jan 16, 2023

Merge Failed.

Zuul merger could not merge this change into the base branch. This is most likely caused by merge conflicts. Please rebase the change and upload the rebased version. In case of further errors, contact the zuul administrator.

@ghost
Copy link

ghost commented Jan 16, 2023

Build succeeded (check pipeline).

@codecov-commenter
Copy link

Codecov Report

Merging #201 (823d432) into master (40fb15b) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #201   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files          75       75           
  Lines        4718     4718           
=======================================
  Hits         4316     4316           
  Misses        402      402           
Impacted Files Coverage Δ
.../workspace/entity_model/content_objects/dataset.py 71.79% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jaceksan jaceksan added the merge label Jan 16, 2023
@yenkins
Copy link

yenkins commented Jan 16, 2023

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-python-sdk-gate-PR201

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Jan 16, 2023
@ghost ghost merged commit d4021e2 into gooddata:master Jan 16, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants