Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SpiceDB API #13

Merged
merged 3 commits into from
Jun 14, 2023
Merged

Update SpiceDB API #13

merged 3 commits into from
Jun 14, 2023

Conversation

ssepml
Copy link
Contributor

@ssepml ssepml commented Jun 14, 2023

Description

This PR includes two changes:

  • Updated the SpiceDB API spec to the latest one which includes support to:
    • Cursors
    • Bulk import / export of relationships
  • Update protobuf to 0.12.0 and updated tests to remove the use of new method as it is now deprecated (see error below)
warning: Authzed.Api.V1.WriteSchemaRequest.new/1 is deprecated. Build the struct by hand with %MyMessage{...} or use struct/2
  test/authzed_test.exs:56: AuthzedTest."test basic operation"/1

Copy link
Owner

@goodhamgupta goodhamgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ssepml! 😄 Since the API has changed now, I think it would be best to also bump up the version of the package(from 0.0.3 to 0.0.4), to avoid breaking changes for people already using the 0.0.3 version.

@ssepml
Copy link
Contributor Author

ssepml commented Jun 14, 2023

Since the API has changed now, I think it would be best to also bump up the version of the package(from 0.0.3 to 0.0.4), to avoid breaking changes for people already using the 0.0.3 version.

Of course, done. And thanks a lot for the quick response 😄

Copy link
Owner

@goodhamgupta goodhamgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you!

@goodhamgupta goodhamgupta merged commit 70f08fb into goodhamgupta:main Jun 14, 2023
@ssepml ssepml deleted the update_api branch June 14, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants