Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write down precise constants in the asymptotic complexity #3

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

girving
Copy link
Contributor

@girving girving commented Aug 16, 2024

  1. Alice takes 5000 k^2 t log t + smaller terms
  2. Bob takes 20000/9 k^2 t log t + smaller terms
  3. Vera takes 106000 * k^2 + 1

1. Alice takes 5000 k^2 t log t + smaller terms
2. Bob takes 20000/9 k^2 t log t + smaller terms
3. Vera takes 106000 * k^2 + 1
@girving
Copy link
Contributor Author

girving commented Aug 16, 2024

@eric-wieser Next one: A bit of refactoring, and then writing down the constants.

@girving
Copy link
Contributor Author

girving commented Aug 17, 2024

(For more context: this is very much related to the original paper, and will be the last PR for a while based on recent discussions.)

Debate/Cost.lean Outdated Show resolved Hide resolved
Copy link
Collaborator

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

Debate/Details.lean Outdated Show resolved Hide resolved
theorem bob_fast (k : ℝ) (k0 : 0 < k) (t : ℕ) (alice : Alice) (vera : Vera) :
let p := defaults k t k0
(debate alice (bob p.s p.b p.q) vera t).cost' o BobId ≤
(t+1) * (20000 / 9 * k^2 * Real.log (200 * (t+1)) + 1) := by
Copy link
Collaborator

@eric-wieser eric-wieser Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it feasible to write a version of this using asymptotics notation, that more closely resembles the docstring? (happy to merge without this)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want the explicit constant version: https://x.com/geoffreyirving/status/1805903946629701764

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you probably mean additionally have the asymptotic versions. I’d like to triage that away for now if possible.

Debate/Cost.lean Outdated Show resolved Hide resolved
Debate/Cost.lean Outdated Show resolved Hide resolved
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@eric-wieser eric-wieser merged commit de3a6e5 into google-deepmind:main Oct 8, 2024
2 checks passed
@girving girving deleted the constant branch October 8, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants