Semantic retriever #168
Merged
Semantic retriever #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I5c4f35238f3bc0bbc798abd72cf824ebe1103152
github-actions
bot
added
status:awaiting review
MarkDaoust
requested changes
Jan 12, 2024
Co-authored-by: Mark Daoust <markdaoust@google.com>
Co-authored-by: Mark Daoust <markdaoust@google.com>
Co-authored-by: Mark Daoust <markdaoust@google.com>
Co-authored-by: Mark Daoust <markdaoust@google.com>
MarkDaoust
reviewed
Jan 19, 2024
MarkDaoust
requested changes
Jan 19, 2024
wilyeye
reviewed
Jan 23, 2024
MarkDaoust
previously requested changes
Jan 25, 2024
pikalaw
reviewed
Jan 25, 2024
| client = get_default_retriever_async_client() | ||
|
|
||
| if results_count: | ||
| if results_count < 0 or results_count >= 100: |
There was a problem hiding this comment.
same here for the result counts
| def delete_document( | ||
| self, | ||
| name: str, | ||
| force: Optional[bool] = None, |
There was a problem hiding this comment.
if the user specifies it wouldn't we pass None to the request on line 444? Either we make the default false or if none, we don't set it in the request in line 444
There was a problem hiding this comment.
I get this:
File "/opt/homebrew/lib/python3.11/site-packages/proto/message.py", line 558, in init
raise TypeError(
TypeError: Invalid constructor input for DeleteDocumentRequest: 'corpusname'
|
We'll resolve the open comments in follow on PRs before making the release. |
MarkDaoust
approved these changes
Jan 30, 2024
github-actions
bot
removed
the
status:awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I5c4f35238f3bc0bbc798abd72cf824ebe1103152
Description of the change
Adding Semantic Retriever Python Client Library.