Add support for resumable uploads for File API #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status:awaiting review
markmcd
reviewed
Apr 11, 2024
MarkDaoust
reviewed
Apr 12, 2024
google/generativeai/client.py
Outdated
| @@ -59,6 +59,8 @@ def create_file( | |||
| mime_type: str | None = None, | |||
| name: str | None = None, | |||
| display_name: str | None = None, | |||
| resumable: bool | None = None, | |||
There was a problem hiding this comment.
Are we exposing too many details here?
Do we need the resumable arg, could it just be resumable=chunk_size is not None?
Is there a reasonable default policy we could implement like "if the file is over (2x)MB use resumable with chunk size (x)MB"?
There was a problem hiding this comment.
Yeah, fair point. After some exploration, how about let's start simple and just allow users to set resumable as a boolean flag? The chunk size needs to be a multiple of a certain size and is unfriendly for developers.
MarkDaoust
approved these changes
May 13, 2024
github-actions
bot
removed
the
status:awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for resumable uploads by following the MediaFileUpload class in Python:
https://googleapis.github.io/google-api-python-client/docs/epy/googleapiclient.http.MediaFileUpload-class.html
Add some pydocs to clarify what the parameters specified are. Confirmed this is working locally: