Use native attributes #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the first step is really the zeroth step, the new runTest implementation was inadvertently doing a serialization immediately after the first step instead of, as intended, only after steps steps.
Changing .length of array should throw if it would cause a nonwritable, nonconfigurable property to be deleted.
These never do anything, but they should do nothing in the correct way.
The most significant change is that the .property objects which serve as dictionaries of own properties inherit from the object's prototype's .property object. Simplifies some things considerably and seems to provide a small performance improvment.
NeilFraser
approved these changes
Mar 10, 2018
server/interpreter.js
Outdated
| this.throwNativeException(e); | ||
| } | ||
| } else if (obj instanceof Interpreter.Sentinel) { | ||
| // Whoops; this should have been caught by acorn (because strict). |
server/interpreter.js
Outdated
| } | ||
| } else if (obj instanceof Interpreter.Sentinel) { | ||
| // Whoops; this should have been caught by acorn (because strict). | ||
| throw Error("Uncaught illegal deletion of unqualified identifier"); |
server/tests/db/test_01_es5.js
Outdated
| // they are all non-configurable, so delete *always* fails). | ||
| tests.deleteOwnFromPrimitive = function() { | ||
| try { | ||
| delete "hello".length; |
There was a problem hiding this comment.
Not that the tests are remotely consistent about that otherwise…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.