WebVTT: Support font-size CSS property #8964
Assignees
Labels
Comments
andrewlewis
pushed a commit
that referenced
this issue
Aug 3, 2021
This CL addresses the github issue [#8946](#8964). That issue requests support for `font-size` CSS property in WebVTT subtitle format. This CL: * Adds support for `font-size` property by extending capabilities of WebVTT `CssParser`. Implementation of `font-size` property value parsing is based on the one in `TtmlDecoder`. * Adds unit test along with test file containing WebVTT subtitles with all currently supported `font-size` units. #minor-release PiperOrigin-RevId: 388423859
christosts
pushed a commit
that referenced
this issue
Aug 11, 2021
This CL addresses the github issue [#8946](#8964). That issue requests support for `font-size` CSS property in WebVTT subtitle format. This CL: * Adds support for `font-size` property by extending capabilities of WebVTT `CssParser`. Implementation of `font-size` property value parsing is based on the one in `TtmlDecoder`. * Adds unit test along with test file containing WebVTT subtitles with all currently supported `font-size` units. #minor-release PiperOrigin-RevId: 388423859
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The
::cuepseudo-element can contain "the properties corresponding to the font shorthand" (spec). This includesfont-size.Lack of support for this was flagged in #8958
Implementing this probably involves editing the WebVTT CssParser.
WebvttCssStylealready has font size support (though it doesn't seem to be used, and I'm not sure it ever has been), so it should be possible to re-use that.The text was updated successfully, but these errors were encountered: