-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GIDSignIn.signIn getting "keychain error" for some users #165
Comments
Can you tell me what version of Google Sign-In you're using when you see this behavior? The version of GTMAppAuth you're building with would also be relevant, as well as the version(s) of iOS you're seeing this on. |
We are having the same problem here.
|
Also seeing this with iOS 15.5, but also iOS 14.7.1 . GTMAppAuth 1.2.3. It was reported today. Still looking to see if the version of iOS is a determining factor. This is an app that is in the store. |
The device I debugged was iOS 15.4.1 but there are many users who reported the issue, I don't know the OS versions of all. |
I'm also having the same issue. Any suggestions would be great. |
I'm also facing this issue today. |
It sounds as though the Keychain is returning an error for some reason, causing Is anyone able to reliably reproduce this behavior in a debug build? If so, you could provide repro steps? |
Yes I could debug it but there are no "steps" to reproduce the bug really, I just call All the users who had trouble logging in have an active Google session in Safari. Sadly, that's all I have. |
If you can reproduce this in a debug build, try setting a breakpoint in GTMAppAuth's |
The "keyChain Error" is not shown in an updated version of GTMAppAuth (1.3.0). |
The status returned in GTMAppAuth (1.2.2). is |
@zaidhafeez thanks for the feedback. For anyone who is (or was) experiencing this behavior, could you list all the third-party libraries you're using and how they're being built / linked (Swift Package Manager, CocoaPods, XCFrameworks, etc). I'm looking for a potential source of conflicting Keychain operations. |
GoogleSignIn(5.0.2) iOS 14.6 |
I can verify that "keychain error" doesn't occur on GTMAppAuth version (1.3.0). |
@alperkayabasi could you let me know which (if any) third-party libraries you're using in addition to Google Sign-In? Please see my previous comment. |
@petea We're using a lot of 3rd party frameworks but I'll try to list major ones.
|
Upgrade to 6.2.2 solve my keychain error problem. |
@iyouqiang I resolved by upgrading 6.0.0 version. but I don't wanna upgrade. I deleted the app once, but I can't login. Anyone can resolved? |
I am also getting the same error for my application. It was working well before. |
Same here, got the issue on my phone with multiple accounts |
I have the same problem
|
For those who are still seeing this issue, please let me know which versions of GoogleSignIn and GTMAppAuth you're building with. |
GoogleSignIn -> 6.1.0 Is there a problem with the simulator? Can it be done on the real machine? |
Upgrade to Google signin 6.2.2 without this problem. The following is the corresponding version
|
Also seeing this issue on iOS 16 beta: GoogleSignIn (6.1.0):
|
Hey! We're running version 6.1.0 and some of our users are experiencing this issue in too. |
Update to latest version which has GTMAppAuth ~> 1.3 will fix the issue |
Thanks a lot Simon! |
After updating my pods to I reproduced the issue on a Mac Silicon with Mac OS Ventura (13.0 (22A380)). But It works on iPad OS 16.1. |
Updating to latest version solved the issue! |
Same here. |
What I am seeing is here... TestFlight Build (with latest SignIn SDK) iPhone 13 / iOS 16.1 - working fine AppStore Build (with old SignIn SDK) iPhone 13 / iOS 16.1 - Keychain error |
Same issue with MacOS testflight build on Apple Silicon, but works fine on any iOS device I've tried. The mentioned workaround of adding key chain sharing ability with "com.google.GIDSignIn" as the only keychain group does fix the issue for iOS testflight builds running on MacOS. |
Add "com.google.GIDSignIn" to Keychain Sharing section of Project Capability, and try again. |
I also encounter this issue, I attached my Podfile.lock at the end. After I add Cheers!
com.google.GIDSignIn
|
OMG, I'm still experiencing the issue on macOS and because of the workaround with the keychain, I see this keychain permission alert. |
For those of you who added |
After updating from GoogleSignIn (7.0.0) to GoogleSignIn (7.1.0) on a macOS app target I got |
@hristoenev are you able to print out the error here in GIDSignIn.m? That should be the error GSI gets from GTMAppAuth here. A breakpoint at either location should tell us more about what the error is. I was able to replicate the error in GSI's SignInSample project. These are the errors. You can see in one of the screenshots that the error in this case is from the keychain: -34018. From here, you will find that this error is due to a missing entitlement. I added that entitlement to the SignInSample project (see below), and was able to save and restore successfully. Last, the DaysUntilBirthday sample and GTMAppAuth sample provide macOS targets. I am not able to reproduce this issue with either of those samples. |
@mdmathias, the error I got from GIDSignIn.m is |
Strange. The main difference, with respect to persisting authorizations, between GSI 7.0.0 and GSI 7.1.1 is that 7.0.0 listed its dependency on GTMAppAuth as this:
7.1.0 updated that dependency to:
This amounted to GSI 7.0.0 depending upon GTMAppAuth v2.0.0. GSI 7.1.0 depends upon GTMAppAuth v4.1.1 and higher. Depending upon GTMAppAuth 4.1+ is important because that is the version of the library with a privacy manifest. In any case, I tried to reproduce your issue by first opening up the DaysUntilBirthday sample from GSI 7.0.0. I built and ran the sample, successfully signing in. Then, I built and ran the same sample app from GSI's 7.1.0 release. The sample app was able to restore the previous sign in and I saw no error. If you are able to, please share as much detail as you can to reproduce your issue. I will make sure to investigate. In the meantime, I'm closing this issue as not reproducible (and also considering that this was originally created in 2022). I will reopen the issue if you're able to repro. Thanks! |
Don't spend too much time on this. The record the SDK made in Keychain had to be deleted. There are two questions for me:
|
|
So the SDK created the |
For anyone having the same issue on Flutter MacOS, I solved by using this dependency override:
which uses GoogleSignIn 7.0.0. Which 7.1 I have the keychain error |
@apaolino Thanks so much I was stuck for few hours! |
Why is this marked closed when the issue still persist in the latest version? GoogleSignin 7.1.0 happens for some of our customers. Cannot reproduce on my own devices. They have macOS 15.0.1. |
We're also seeing this error all of a sudden (not sure if it's specific to macOS 15 Sequoia). Ours is a macOS app using Firebase for auth. Unfortunately we're unable to reproduce this issue consistently. And there doesn't seem to be a workaround for users who do hit this issue. GoogleSignIn: 8.0.0 |
Hello,
We are using GoogleSignIn for a few years. Suddenly, some users start to get "com.google.GIDSignIn / error code: -2 / keychain error" and we can't sign them in to our application.
To fix this, I have to enable "keychain sharing access" in my project settings (we have never enabled this and it was working as expected for a long time) and add "com.google.GIDSignIn" as keychain group.
Here is the screenshot;
If I use my own bundle id here I still get the same error, I have to add com.google.GIDSignIn specifically.
This is not one of the steps to integrate the SDK and I don't know why it is neccessary to add "com.google.GIDSignIn" keychain sharing access in my project.
Can you help with the issue?
Thank you.
The text was updated successfully, but these errors were encountered: