Bugfix #304
Merged
Bugfix #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: superskybird <skybird.le@gmail.com>
…#284) * Fix fido2 API update. Since fido2 0.8.1 the device descriptor moved to NamedTuple, breaking our configuration tool. Code is now updated accordingly and the setup script ensure we're using the correct version for fido2 package. * Make Yapf happy * Fix missing update for fido2 0.9.1 Also split the comment into 2 lines so that the touch is not hidden at the end of the screen.
ia0
approved these changes
Apr 13, 2021
kaczmarczyck
approved these changes
Apr 13, 2021
kaczmarczyck
added a commit
that referenced
this pull request
Sep 10, 2021
* Add Feitian OpenSK USB Dongle (#257) (#258) Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> * Bugfix (#304) * Add Feitian OpenSK USB Dongle (#257) Co-authored-by: superskybird <skybird.le@gmail.com> * Fix `config.py` tool according to the new API of fido2 python package (#284) * Fix fido2 API update. Since fido2 0.8.1 the device descriptor moved to NamedTuple, breaking our configuration tool. Code is now updated accordingly and the setup script ensure we're using the correct version for fido2 package. * Make Yapf happy * Fix missing update for fido2 0.9.1 Also split the comment into 2 lines so that the touch is not hidden at the end of the screen. * adds README changes, logo and certificate (#285) Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> * Compare all timestamps in UTC timezone. (#309) * Merge bugfix into stable (#324) * Add Feitian OpenSK USB Dongle (#257) Co-authored-by: superskybird <skybird.le@gmail.com> * Fix `config.py` tool according to the new API of fido2 python package (#284) * Fix fido2 API update. Since fido2 0.8.1 the device descriptor moved to NamedTuple, breaking our configuration tool. Code is now updated accordingly and the setup script ensure we're using the correct version for fido2 package. * Make Yapf happy * Fix missing update for fido2 0.9.1 Also split the comment into 2 lines so that the touch is not hidden at the end of the screen. * adds README changes, logo and certificate (#285) * Fix broken parsing. (#317) * Fix broken parsing. By setting the default value before pre-parsing we ensure that the item can't be None. As an extra safety the custom action also checks for None. Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> * Coveralls workflow applied also to stable (#342) * Coveralls (#339) * Add code coverage report as part of the workflows * Remove -Clink-dead-code which seems to be problematic * Manually set features to avoid debug_* failing unit tests. * Update badges * Add libraries directory to trigger code coverage reporting. * Fix coveralls badge not pointing to the branch * Badges to stable branch * adds and links new security policy * Add erase_storage application example (#352) * Fix coveralls workflow (#356) * Return error instead of debug assert (#363) With dirty storage we hit the assert. Returning an error permits to continue to catch if the invariant is broken for normal operation while being able to continue fuzzing with dirty storage. * Remove elf2tab dev-dependency (#366) We don't use it anymore. Not sure when we used to use it. Fixes #364 Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> * Install Rust tools with stable compiler We only need the frozen nightly for Tock (and maybe the app). * fix python lint with encoding, see commit 7418196 * more encoding Co-authored-by: Jean-Michel Picod <jmichel@google.com> Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: Julien Cretin <cretin@google.com>
kaczmarczyck
added a commit
to kaczmarczyck/OpenSK
that referenced
this pull request
Nov 19, 2021
* Add Feitian OpenSK USB Dongle (google#257) (google#258) Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> * Bugfix (google#304) * Add Feitian OpenSK USB Dongle (google#257) Co-authored-by: superskybird <skybird.le@gmail.com> * Fix `config.py` tool according to the new API of fido2 python package (google#284) * Fix fido2 API update. Since fido2 0.8.1 the device descriptor moved to NamedTuple, breaking our configuration tool. Code is now updated accordingly and the setup script ensure we're using the correct version for fido2 package. * Make Yapf happy * Fix missing update for fido2 0.9.1 Also split the comment into 2 lines so that the touch is not hidden at the end of the screen. * adds README changes, logo and certificate (google#285) Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> * Compare all timestamps in UTC timezone. (google#309) * Merge bugfix into stable (google#324) * Add Feitian OpenSK USB Dongle (google#257) Co-authored-by: superskybird <skybird.le@gmail.com> * Fix `config.py` tool according to the new API of fido2 python package (google#284) * Fix fido2 API update. Since fido2 0.8.1 the device descriptor moved to NamedTuple, breaking our configuration tool. Code is now updated accordingly and the setup script ensure we're using the correct version for fido2 package. * Make Yapf happy * Fix missing update for fido2 0.9.1 Also split the comment into 2 lines so that the touch is not hidden at the end of the screen. * adds README changes, logo and certificate (google#285) * Fix broken parsing. (google#317) * Fix broken parsing. By setting the default value before pre-parsing we ensure that the item can't be None. As an extra safety the custom action also checks for None. Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> * Coveralls workflow applied also to stable (google#342) * Coveralls (google#339) * Add code coverage report as part of the workflows * Remove -Clink-dead-code which seems to be problematic * Manually set features to avoid debug_* failing unit tests. * Update badges * Add libraries directory to trigger code coverage reporting. * Fix coveralls badge not pointing to the branch * Badges to stable branch * adds and links new security policy * Add erase_storage application example (google#352) * Fix coveralls workflow (google#356) * Return error instead of debug assert (google#363) With dirty storage we hit the assert. Returning an error permits to continue to catch if the invariant is broken for normal operation while being able to continue fuzzing with dirty storage. * Remove elf2tab dev-dependency (google#366) We don't use it anymore. Not sure when we used to use it. Fixes google#364 Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> * Install Rust tools with stable compiler We only need the frozen nightly for Tock (and maybe the app). * fix python lint with encoding, see commit 7418196 * more encoding Co-authored-by: Jean-Michel Picod <jmichel@google.com> Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: Julien Cretin <cretin@google.com>
kaczmarczyck
added a commit
that referenced
this pull request
Nov 19, 2021
* Add Feitian OpenSK USB Dongle (#257) (#258) Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> * Bugfix (#304) * Add Feitian OpenSK USB Dongle (#257) Co-authored-by: superskybird <skybird.le@gmail.com> * Fix `config.py` tool according to the new API of fido2 python package (#284) * Fix fido2 API update. Since fido2 0.8.1 the device descriptor moved to NamedTuple, breaking our configuration tool. Code is now updated accordingly and the setup script ensure we're using the correct version for fido2 package. * Make Yapf happy * Fix missing update for fido2 0.9.1 Also split the comment into 2 lines so that the touch is not hidden at the end of the screen. * adds README changes, logo and certificate (#285) Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> * Compare all timestamps in UTC timezone. (#309) * Merge bugfix into stable (#324) * Add Feitian OpenSK USB Dongle (#257) Co-authored-by: superskybird <skybird.le@gmail.com> * Fix `config.py` tool according to the new API of fido2 python package (#284) * Fix fido2 API update. Since fido2 0.8.1 the device descriptor moved to NamedTuple, breaking our configuration tool. Code is now updated accordingly and the setup script ensure we're using the correct version for fido2 package. * Make Yapf happy * Fix missing update for fido2 0.9.1 Also split the comment into 2 lines so that the touch is not hidden at the end of the screen. * adds README changes, logo and certificate (#285) * Fix broken parsing. (#317) * Fix broken parsing. By setting the default value before pre-parsing we ensure that the item can't be None. As an extra safety the custom action also checks for None. Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> * Coveralls workflow applied also to stable (#342) * Coveralls (#339) * Add code coverage report as part of the workflows * Remove -Clink-dead-code which seems to be problematic * Manually set features to avoid debug_* failing unit tests. * Update badges * Add libraries directory to trigger code coverage reporting. * Fix coveralls badge not pointing to the branch * Badges to stable branch * adds and links new security policy * Add erase_storage application example (#352) * Fix coveralls workflow (#356) * Return error instead of debug assert (#363) With dirty storage we hit the assert. Returning an error permits to continue to catch if the invariant is broken for normal operation while being able to continue fuzzing with dirty storage. * Remove elf2tab dev-dependency (#366) We don't use it anymore. Not sure when we used to use it. Fixes #364 Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> * Install Rust tools with stable compiler We only need the frozen nightly for Tock (and maybe the app). * fix python lint with encoding, see commit 7418196 * more encoding Co-authored-by: Jean-Michel Picod <jmichel@google.com> Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: Julien Cretin <cretin@google.com>
kaczmarczyck
added a commit
to kaczmarczyck/OpenSK
that referenced
this pull request
Aug 23, 2022
* Add Feitian OpenSK USB Dongle (google#257) (google#258) Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> * Bugfix (google#304) * Add Feitian OpenSK USB Dongle (google#257) Co-authored-by: superskybird <skybird.le@gmail.com> * Fix `config.py` tool according to the new API of fido2 python package (google#284) * Fix fido2 API update. Since fido2 0.8.1 the device descriptor moved to NamedTuple, breaking our configuration tool. Code is now updated accordingly and the setup script ensure we're using the correct version for fido2 package. * Make Yapf happy * Fix missing update for fido2 0.9.1 Also split the comment into 2 lines so that the touch is not hidden at the end of the screen. * adds README changes, logo and certificate (google#285) Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> * Compare all timestamps in UTC timezone. (google#309) * Merge bugfix into stable (google#324) * Add Feitian OpenSK USB Dongle (google#257) Co-authored-by: superskybird <skybird.le@gmail.com> * Fix `config.py` tool according to the new API of fido2 python package (google#284) * Fix fido2 API update. Since fido2 0.8.1 the device descriptor moved to NamedTuple, breaking our configuration tool. Code is now updated accordingly and the setup script ensure we're using the correct version for fido2 package. * Make Yapf happy * Fix missing update for fido2 0.9.1 Also split the comment into 2 lines so that the touch is not hidden at the end of the screen. * adds README changes, logo and certificate (google#285) * Fix broken parsing. (google#317) * Fix broken parsing. By setting the default value before pre-parsing we ensure that the item can't be None. As an extra safety the custom action also checks for None. Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> * Coveralls workflow applied also to stable (google#342) * Coveralls (google#339) * Add code coverage report as part of the workflows * Remove -Clink-dead-code which seems to be problematic * Manually set features to avoid debug_* failing unit tests. * Update badges * Add libraries directory to trigger code coverage reporting. * Fix coveralls badge not pointing to the branch * Badges to stable branch * adds and links new security policy * Add erase_storage application example (google#352) * Fix coveralls workflow (google#356) * Return error instead of debug assert (google#363) With dirty storage we hit the assert. Returning an error permits to continue to catch if the invariant is broken for normal operation while being able to continue fuzzing with dirty storage. * Remove elf2tab dev-dependency (google#366) We don't use it anymore. Not sure when we used to use it. Fixes google#364 Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> * Install Rust tools with stable compiler We only need the frozen nightly for Tock (and maybe the app). * fix python lint with encoding, see commit 7418196 * more encoding Co-authored-by: Jean-Michel Picod <jmichel@google.com> Co-authored-by: Geoffrey <geoffrey@ftsafe.com> Co-authored-by: superskybird <skybird.le@gmail.com> Co-authored-by: Julien Cretin <cretin@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #301
Fixes the new API for python3 fido2 package and some documentation.