Add WAsm SIMD microkernel for f32-rsqrt.
#6280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_624151682
branch
from
834db86
to
50614da
Compare
PiperOrigin-RevId: 624151682
copybara-service
bot
force-pushed
the
test_624151682
branch
from
50614da
to
ea546fa
Compare
fbarchard
reviewed
May 21, 2024
|
|
||
| const v128_t vt0123 = wasm_f32x4_sqrt(vx0123); | ||
| const v128_t vt4567 = wasm_f32x4_sqrt(vx4567); | ||
| const v128_t vy0123 = wasm_f32x4_div(vone, vt0123); |
There was a problem hiding this comment.
some cpus dont support div, such as arm. Is there an alternative way to get reciprocal?
There was a problem hiding this comment.
Not really, since WASM SIMD does not support rcp or rsqrt approximations, since they would not be identical across all platforms.
We could compute an rsqrt approximation ourselves, e.g. a polynomial, but I doubt that would be faster than whatever WASM would to under the hood here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
WAsm SIMDmicrokernel forf32-rsqrt.