Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AndroidDrawablePainter #110

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Update AndroidDrawablePainter #110

merged 2 commits into from
Oct 6, 2020

Conversation

chrisbanes
Copy link
Contributor

@chrisbanes chrisbanes commented Oct 6, 2020 •
edited
Loading

  • Fixes intrinsic size using width for height 🤦
  • Now works with Drawables which change intrinsic size (hello LottieDrawable)
  • Now properly scales drawables as per ContentScale (through the canvas size)

@chrisbanes
Update AndroidDrawablePainter
b5450a4 
- Fixes instrinsic size using width for height
- Now works with Drawables which change intrinsic size
  (hello LottieDrawable)
- Now properly scales drawables as per ContentScale (through
  the canvas size)
@chrisbanes chrisbanes merged commit 4cf088f into main Oct 6, 2020
@chrisbanes chrisbanes deleted the cb/drawable-painter-fixes branch October 6, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickbutcher nickbutcher Awaiting requested review from nickbutcher

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisbanes @googlebot