Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pager] Deprecating accompanist pager in favour of androidx pager. #1504

Merged
merged 17 commits into from
Mar 8, 2023

Conversation

riggaroo
Copy link
Collaborator

@riggaroo riggaroo commented Jan 31, 2023

Deprecating HorizontalPager and VerticalPager in accompanist.

Fixes #1463

@riggaroo
Copy link
Collaborator Author

riggaroo commented Feb 6, 2023

@bentrengrove What command do I run to indicate an API change? Can we add that info to CONTRIBUTING.md? 🙇🏻

Found it thanks to @Levi-Moreira :) updated Contributing to include it

@riggaroo riggaroo marked this pull request as ready for review February 6, 2023 11:12
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/pager.md Outdated Show resolved Hide resolved
Co-authored-by: Ben Trengrove <bentrengrove@users.noreply.github.com>
@@ -29,3 +29,13 @@ All submissions, including submissions by project members, require review. We
use GitHub pull requests for this purpose. Consult
[GitHub Help](https://help.github.com/articles/about-pull-requests/) for more
information on using pull requests.

## API Changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Pager] Add migration guide to new Pager API in androidx.compose.foundation
3 participants