[AppCompatTheme] Migrate AppCompat-Theme gradle file to Kotlin DSL #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oas004
commented
Apr 16, 2023
|
|
||
| lint { | ||
| textReport = true | ||
| textOutput = File("stdout") |
There was a problem hiding this comment.
I'm unsure about this, but will set it to the same as we decide in #1579 (comment)
There was a problem hiding this comment.
I think that is ok for now, although we should check that CI still fails when a lint error is present
oas004
force-pushed
the
feature/appcompat-theme-kts
branch
from
7d03510
to
797a1a0
Compare
oas004
force-pushed
the
feature/appcompat-theme-kts
branch
from
797a1a0
to
591654e
Compare
bentrengrove
approved these changes
May 3, 2023
|
|
||
| lint { | ||
| textReport = true | ||
| textOutput = File("stdout") |
There was a problem hiding this comment.
I think that is ok for now, although we should check that CI still fails when a lint error is present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up #1578 and relating to #1579
Migrating the
:appcompat-thememodule to Kotlin DSL.I have split up the PR into two commits. The first one prepares the file to be migrated by using steps described in these docs. The second one is where I actually convert the file to .kts file and updates the rest of the file to be compatible with Kotlin DSL.