[Image] Throw exception if incorrect data type is passed in #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlideImage, CoilImage and PicassoImage currently all accept an `Any` param for data. There have been examples of developers passing in things like Drawables, ImageBitmaps, and others, which are not supported. To aid developers, we now throw an exception when any Drawable, ImageBitmap, ImageVector or Painter is passed in.
chrisbanes
changed the title
nickbutcher
approved these changes
Dec 7, 2020
|
I don't really want to maintain more overloads for each type which each library supports. We could wrap the data param in a sealed class to enforce the type, but that adds friction for usage (and we'd need to maintain the whitelist for each library). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GlideImage, CoilImage and PicassoImage currently all accept an
Anyparam for data. There have been examples of developers passing in things like Drawables, ImageBitmaps, and others, which are not supported. To aid developers, we now throw an exception when anyDrawable,ImageBitmap,ImageVectororPainteris passed in.