Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info in GPU Counter failures, misc fixes to validation #1261

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

ttanatb
Copy link
Contributor

@ttanatb ttanatb commented Jan 5, 2023

  • Fixed generic validator check.
    • Previously it required every value to be over 0, but now it checks to make sure that not all of the value is 0.
  • Made sure to include trace result in validation error.
  • Adjusted the GPU counter check to list out missing counter (not just ones that failed the check).
    • Made the logs way more expressive as well.
    • Also trimmed duplicates from the check (querying counters can return duplicate counters as data sources).

Changing ones of the check in Adreno validation
Screenshot 2023-01-05 at 10 09 12 PM

Exynos currently doesn't have proper support for GPU profiling, this reports a full list of counters we couldn't trace
Screenshot 2023-01-05 at 10 10 43 PM

@yalcinmelihyasin
Copy link
Contributor

LGTM but please rebase on latest master for the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants