Add option to use PRIVMSG instead of NOTICE #1
Conversation
This is desirable in some situations.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
Note: I'm not going to sign the CLA. My changes are available under the license in my fork, which is unchanged from your license. Take it or leave it. |
|
Thank you Drew. Leaving the licensing topic on the side for a second, I'd like to have a better understanding of the reason behind this request. As far as I can see in the IRC RFC, NOTICE is typically used for automation because, unlike PRIVMSG, "automatic replies MUST NEVER be sent in response to a NOTICE message". Could you provide a few examples of situations in which PRIVMSG should be used instead of NOTICE ? Thank you, Luca |
|
Hey @shammash, on IRC the use of NOTICE or PRIVMSG is not quite as distinct as it once might have been. In practice they're not semantically different, but they do have practical differences which can make them better or worse. For example, for moderation - if you have a bot which use NOTICEs, you must enable NOTICEs for all users, including banned users. PRIVMSG can be moderated more effectively, however. Additionally, some users just prefer the UX of PRIVMSG over NOTICE in their client. |
|
Oh, and if your channel has only one bot in it, or your bot's don't overlap, then it's not going to be a problem in practice, given the reasons you pointed out. |
|
Thank you Drew for the additional details. Now, given that signing the CLA is mandatory for contributing directly with a pull request, is it ok for you to consider this an issue / feature request? I will reimplement the feature you are asking for. Thank you, Luca |
|
Do as you like. Consider me a concientous objector to the CLA. |
Use a more generic name as there is soon going to be support for PRIVMSG (see #1 for background). This introduces a backward-incompatible change in the config file for these two parameters: - notice_template -> msg_template - notice_once_per_alert_group -> msg_once_per_alert_group I am not introducing the new parameters with a deprecation plan since both parameters are relatively secondary to the core functioning of the bot (and this is a free time project after all). Signed-off-by: Luca Bigliardi <shammash@google.com>
Add `use_privmsg` config option to deliver alerts with PRIVMSG instead of the default NOTICE. This addresses a use case described in #1 . Signed-off-by: Luca Bigliardi <shammash@google.com>
|
Hi Drew, ae6594c added use_privmsg . I am going to close this PR. Please feel free to open an issue if you need other features. Thank you, Luca |
|
Thank you. |
This is desirable in some situations.
I've also included a separate commit which updates this package to use Go modules.