SwiftShader part of the build fails #999
Comments
|
Created upstream issue https://issuetracker.google.com/issues/261755036 |
|
Hm. SwiftShader removed the debugger support. https://swiftshader-review.googlesource.com/c/SwiftShader/+/68808 |
dneto0
added a commit
to dneto0/amber
that referenced
this issue
Dec 7, 2022
Fixes: google#999 Change-Id: I5db46ca691a476d271e4b652e2319a18bd4119ab
ben-clayton
pushed a commit
to ben-clayton/amber
that referenced
this issue
Dec 8, 2022
SwiftShader was the only implementation that supported this, but has disabled this code due to lack of use. If there's no driver that supports shader debugging, then it doesn't need to exist and be maintained in Amber. If one day, we want this again, then this CL can be reverted. Fixes: google#999
ben-clayton
pushed a commit
to ben-clayton/amber
that referenced
this issue
Dec 8, 2022
SwiftShader was the only implementation that supported this, but has disabled this code due to lack of use. If there's no driver that supports shader debugging, then it doesn't need to exist and be maintained in Amber. If one day, we want this again, then this CL can be reverted. Fixes: google#999
dneto0
added a commit
that referenced
this issue
Dec 8, 2022
* Remove shader debugging from Amber SwiftShader was the only implementation that supported this, but has disabled this code due to lack of use. If there's no driver that supports shader debugging, then it doesn't need to exist and be maintained in Amber. If one day, we want this again, then this CL can be reverted. Fixes: #999 * Fix Kokoro build failures due to git errors About "detected dubious ownership" Co-authored-by: David Neto <dneto@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Building from scratch with the DEPS as specified, I get this compile error on Ubuntu with Clang-14 as the compiler:
[12/125] Building CXX object third_party/swiftshader/src/Vulkan/CMakeFiles/vk_swiftshader.dir/Debug/EventListener.cpp.o
FAILED: third_party/swiftshader/src/Vulkan/CMakeFiles/vk_swiftshader.dir/Debug/EventListener.cpp.o
/usr/bin/clang++ -DAMBER_CTS_VULKAN_HEADER=0 -DAMBER_ENABLE_CLSPV=0 -DAMBER_ENABLE_DXC=0 -DAMBER_ENABLE_LODEPNG=1 -DAMBER_ENABLE_RTTI=0 -DAMBER_ENABLE_SHADERC=1 -DAMBER_ENABLE_SPIRV_TOOLS=1 -DAMBER_ENABLE_VK_DEBUGGING=1 -DAMBER_ENGINE_DAWN=0 -DAMBER_ENGINE_VULKAN=1 -DENABLE_VK_DEBUGGER -DREACTOR_ENABLE_MEMORY_SANITIZER_INSTRUMENTATION -DSWIFTSHADER_ENABLE_ASTC -DVK_EXPORT="" -DVK_USE_PLATFORM_XCB_KHR -Dvk_swiftshader_EXPORTS -I/build/amber/amber/include -I/build/amber/amber -I/build/amber/amber/third_party/spirv-tools/include -I/build/amber/amber/third_party/swiftshader/src/Vulkan/.. -I/build/amber/amber/third_party/swiftshader/src/System/.. -I/build/amber/amber/third_party/swiftshader/third_party/marl/include -I/build/amber/amber/third_party/swiftshader/src/Pipeline/.. -I/build/amber/amber/third_party/swiftshader/include -I/build/amber/amber/third_party/spirv-headers/include -I/build/amber/amber/third_party/swiftshader/src/Pipeline -I/build/amber/amber/third_party/swiftshader/src/Device/.. -I/build/amber/amber/third_party/swiftshader/third_party/astc-encoder/Source -I/build/amber/amber/third_party/swiftshader/src/WSI/.. -I/build/amber/amber/third_party/swiftshader/src/Reactor/. -I/build/amber/amber/third_party/cppdap/include -m64 -fPIC -march=x86-64 -mtune=generic -O3 -DNDEBUG -Os -DNDEBUG -ffunction-sections -fdata-sections -fomit-frame-pointer -fPIC -Wall -Wreorder -Wsign-compare -Wmissing-braces -Wextra -Wunreachable-code-loop-increment -Wunused-lambda-capture -Wstring-conversion -Wextra-semi -Wignored-qualifiers -Wdeprecated-copy -Wno-unneeded-internal-declaration -Wno-unused-private-field -Wno-comment -Wno-extra-semi -Wno-unused-parameter -Wno-unknown-warning-option -DSWIFTSHADER_LOGGING_LEVEL=Error -fno-exceptions -Wthread-safety -std=gnu++17 -MD -MT third_party/swiftshader/src/Vulkan/CMakeFiles/vk_swiftshader.dir/Debug/EventListener.cpp.o -MF third_party/swiftshader/src/Vulkan/CMakeFiles/vk_swiftshader.dir/Debug/EventListener.cpp.o.d -o third_party/swiftshader/src/Vulkan/CMakeFiles/vk_swiftshader.dir/Debug/EventListener.cpp.o -c /build/amber/amber/third_party/swiftshader/src/Vulkan/Debug/EventListener.cpp
In file included from /build/amber/amber/third_party/swiftshader/src/Vulkan/Debug/EventListener.cpp:15:
/build/amber/amber/third_party/swiftshader/src/Vulkan/Debug/EventListener.hpp:60:42: error: no type named 'string' in namespace 'std'
virtual void onSetBreakpoint(const std::string &func, bool &handled) {}
~~~~~^
My config line:
cmake -GNinja -DCMAKE_BUILD_TYPE=Release
-DCMAKE_CXX_COMPILER=clang++
-DCMAKE_C_COMPILER=clang
-DAMBER_USE_DXC=OFF
-DAMBER_ENABLE_SWIFTSHADER=TRUE
-DAMBER_ENABLE_VK_DEBUGGING=TRUE
$AMBER_DIR
The text was updated successfully, but these errors were encountered: