Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky QuestionnaireUiEspressoTest$dateTimePicker_shouldSetAnswerWhenDateAndTimeAreFilled has 12/24h problem #2485

Closed
vorburger opened this issue Mar 16, 2024 · 1 comment · Fixed by #2489
Assignees
Labels
P1 High priority issue

Comments

@vorburger
Copy link
Member

Describe the bug

A new flaky test is slowing down development velocity on unrelated work; this and this
ran into:

expected: 2005-01-05T06:10 but was : 2005-01-05T18:10 at com.google.android.fhir.datacapture.test.QuestionnaireUiEspressoTest$dateTimePicker_shouldSetAnswerWhenDateAndTimeAreFilled$1.invokeSuspend(QuestionnaireUiEspressoTest.kt:255)

This has been noticed e.g. in #2471, and it's now also blocking merging #2463 to fix #2237, which in turn is holding up #2483.

Component
Datacapture

To Reproduce
Raise a PR and it Kokoro fails due to something unrelated to what you are working on .

Expected behavior
Tests which are unrelated to the current change must always pass.

Would you like to work on the issue?
I'll see if I propose a PR to disable (ignore) that test.

I don't want to work on fixing that test - but perhaps someone else is interesting in picking this up?

@jingtang10
Copy link
Collaborator

thanks for raising this @vorburger

@MJ1998 MJ1998 added the P1 High priority issue label Jun 27, 2024
@MJ1998 MJ1998 self-assigned this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority issue
Projects
Status: Complete
3 participants