Submit button placement #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@googlebot I signed it! |
|
I think if we follow Fred's suggestion in #131 we'd have to consider not rendering the submit button as part of the library at all. So, the library is in charge of the questionnaire items and collecting answers, but the application would render a button and if the user clicks that button the application will ask the library (the questionnaire fragment) what has been recorded by the user. I think if we do keep the button (and perhaps that should be an option) in the library, then it perhaps should be another view holder type in the recycler view. Same thing with the header (questionnaire title). @yigit for comment too. |
2. Bug fixes to the tests to use Material components correctly
2. Added newInstance in companion object to get the questionnaire from Parent activity
… activity is first created. 2. Passing questionnaire to fragment via newInstance
2. Passing Questionnaire and QuestionnaireResponse to as Fragment.arguments
…ject throws "parcelable encountered ioexception writing serializable object" when app is minimized
… in questionnaire activity
…nt and return the current Questionnaire response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #131 . The questionnaire_fragment.xml used a linear layout which resulted in the submit button vanishing when the questionnaire is long. As advised in issue #131, the submit button should be pinned to the top right corner. I have used a constraintLayout to get this done.