Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show asterisk in flyover text if question text is not present and questionnaire item is required. #1762

Closed

Conversation

santosh-pingle
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #544

Description
Clear and concise code change description.

  • If question text is not present and questionnaire item is required then show asterisk in flyover text of sdc widgets which uses text input text layout (Edit text).

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Feature

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@santosh-pingle
Copy link
Collaborator Author

@shelaghm
All attached screenshots does not have question text and questionnaire item is required (mandatory).

Screen Shot 2022-12-12 at 3 41 54 PM

Screen Shot 2022-12-12 at 3 42 26 PM

Screen Shot 2022-12-12 at 3 42 57 PM

Screen Shot 2022-12-12 at 3 43 33 PM

Screen Shot 2022-12-12 at 3 44 04 PM

@shelaghm
Copy link

@santosh-pingle Looks good! Thanks

@omarismail94
Copy link
Contributor

@santosh-pingle did we resolve whether we wanted * required to appear on the bottom of all questions?

@santosh-pingle
Copy link
Collaborator Author

santosh-pingle commented Dec 14, 2022

@santosh-pingle did we resolve whether we wanted * required to appear on the bottom of all questions?

I will start this thread in issue #544.
#544 (comment)

As per comment from @shelaghm, it is encouraged to use it.

@omarismail94
Copy link
Contributor

Thanks @santosh-pingle ! LGTM!

@omarismail94
Copy link
Contributor

We will wait for @shelaghm actually to get back to @jingtang10 's comment in the Issue #544 before approving

@shelaghm
Copy link

@omarismail94 @santosh-pingle I've commented over on #544 let me know if either of you have thoughts as well :)

@jingtang10 jingtang10 assigned santosh-pingle and unassigned shelaghm Jan 5, 2023
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we're gonna not use asterisk at all as the result of UX research findings and discussions with @shelaghm.

sorry that you'll need to rework this pr.

@@ -44,6 +44,7 @@
<string name="not_answered">"Not Answered"</string>
<string name="help">Help</string>
<string name="space_asterisk">\u0020\u002a</string>
<string name="required">\u002arequired</string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<string name="required">\u002arequired</string>
<string name="required">Required</string>

@shelaghm
Copy link

Let's wait while we get some input from the community on how they use required and then make a decision on how we re-work this issue. So far we've heard from Ona's designers. Will be great to hear from a few others how they are using this feature in their deployments.

@shelaghm
Copy link

FYI #544 Ona uses Optional instead of Required.

@FikriMilano
Copy link
Collaborator

@santosh-pingle can we make this configurable? would like to show nothing if required and show Optional if not required

@jingtang10
Copy link
Collaborator

@santosh-pingle can we close this PR now given it's also out of date?

we can reopen/create a new PR once we have conclusion on UX.

@jingtang10
Copy link
Collaborator

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "required" text for required fields in Questionaire
5 participants