Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create nested items correctly #1881

Merged
merged 11 commits into from
Feb 22, 2023
Merged

Create nested items correctly #1881

merged 11 commits into from
Feb 22, 2023

Conversation

jingtang10
Copy link
Collaborator

@jingtang10 jingtang10 commented Feb 22, 2023

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1812 #1784 #487

Description

  • Correct the logic to generate questionnaire item view items for nested items
  • Improve documentation for a number of existing functions
  • Stop creating unnecessary new questionnaire response items during questionnaire state generation

Alternative(s) considered
NA

Type
Bug fix

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

jingtang10 and others added 3 commits February 22, 2023 18:48
…MoreQuestionnaireItemComponents.kt

Co-authored-by: Omar Ismail <44980219+omarismail94@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants