Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FHIRPath constant value null casting bug fix #2012

Merged
merged 6 commits into from
Jun 7, 2023

Conversation

FikriMilano
Copy link
Collaborator

@FikriMilano FikriMilano commented May 23, 2023

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2011

Description
Use safe casting

Alternative(s) considered
N/A

Type
Bug fix

Screenshots (if applicable)
N/A

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@FikriMilano FikriMilano requested review from a team and santosh-pingle as code owners May 23, 2023 01:32
Copy link
Collaborator

@santosh-pingle santosh-pingle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! @FikriMilano
LGTM,

@FikriMilano
Copy link
Collaborator Author

@santosh-pingle can you merge the PR as well? I don't have write access to do that

@santosh-pingle
Copy link
Collaborator

@santosh-pingle can you merge the PR as well? I don't have write access to do that

@jingtang10 Can you please review it

@jingtang10 jingtang10 merged commit e322dd4 into google:master Jun 7, 2023
@jingtang10 jingtang10 deleted the 2011-fhirpath-null-casting-bug branch June 7, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

FHIRPath casts a null value to a Base class bug
4 participants