Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement questionnaire-unit and questionnaire-unitOption extensions #2014

Merged
merged 17 commits into from
Aug 21, 2023

Conversation

jingtang10
Copy link
Collaborator

@jingtang10 jingtang10 commented May 25, 2023

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1550
Fixes #1600

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@santosh-pingle
Copy link
Collaborator

@jingtang10
Can you please upload the screenshots?

Copy link
Collaborator

@santosh-pingle santosh-pingle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please write unit tests to check whether units are shown as per the questionnaire-unitOption, questionnaire-unit?

@santosh-pingle
Copy link
Collaborator

santosh-pingle commented May 29, 2023

Please declare @dimen/padding_default to dimens.xml.

@santosh-pingle
Copy link
Collaborator

santosh-pingle commented May 31, 2023

@jingtang10 is it okay to link below issue here, (quantity value is not populated)
#2013

@jingtang10
Copy link
Collaborator Author

@jingtang10
Can you please upload the screenshots?

Screenshot_20230817-114142.png

Screenshot_20230817-114130.png

Screenshot_20230817-114135.png

@jingtang10
Copy link
Collaborator Author

Please declare @dimen/padding_default to dimens.xml.

is this comment still valid? sorry i'm not sure what to do here. thanks!

@jingtang10
Copy link
Collaborator Author

Can you please write unit tests to check whether units are shown as per the questionnaire-unitOption, questionnaire-unit?

done

@santosh-pingle santosh-pingle self-requested a review August 18, 2023 04:46
Copy link
Collaborator

@santosh-pingle santosh-pingle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jingtang10 thanks!

@jingtang10 jingtang10 merged commit 7f79e26 into google:master Aug 21, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Add support for unitOption and/or unitValueSet Add support for the questionnaire-unit extension
3 participants