Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload work manager #2022

Merged
merged 27 commits into from
Jul 31, 2023
Merged

Upload work manager #2022

merged 27 commits into from
Jul 31, 2023

Conversation

anchita-g
Copy link
Collaborator

@anchita-g anchita-g commented Jun 1, 2023 •
edited
Loading

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2021

Description

  • Create an interface for UploadWorkManager which will be able to orchestrate over what to upload from the list of local changes and how to upload (create Bundle or individual requests from the list of changes to be uploaded)
  • Refactored the existing BundleUploader to be used as a default way to create Bundles from LocalChanges

Alternative(s) considered
NA

Type
Feature

Screenshots (if applicable)
upload-worker

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@anchita-g anchita-g requested review from a team and santosh-pingle as code owners June 1, 2023 04:04
@anchita-g anchita-g requested a review from aditya-07 June 1, 2023 04:04
@anchita-g anchita-g marked this pull request as draft June 1, 2023 09:52
@anchita-g anchita-g marked this pull request as ready for review June 2, 2023 06:44
@anchita-g anchita-g marked this pull request as draft July 7, 2023 09:28
@anchita-g anchita-g marked this pull request as ready for review July 10, 2023 10:00
@anchita-g anchita-g marked this pull request as draft July 10, 2023 10:34
@anchita-g anchita-g marked this pull request as ready for review July 11, 2023 08:55
@anchita-g
Copy link
Collaborator Author

To contain the size of the changes, I have just added major refactoring and interface changes in this PR. I will follow this one with another PR to support other upload requests (per resource based uploads).

omarismail94
omarismail94 reviewed Jul 12, 2023
View reviewed changes
engine/src/main/java/com/google/android/fhir/db/Database.kt Outdated Show resolved Hide resolved
engine/src/main/java/com/google/android/fhir/sync/UploadWorkManager.kt Outdated Show resolved Hide resolved
engine/src/main/java/com/google/android/fhir/sync/Uploader.kt Outdated Show resolved Hide resolved
engine/src/main/java/com/google/android/fhir/sync/Uploader.kt Outdated Show resolved Hide resolved
engine/src/main/java/com/google/android/fhir/sync/remote/FhirHttpDataSource.kt Show resolved Hide resolved
engine/src/main/java/com/google/android/fhir/sync/remote/FhirHttpDataSource.kt Outdated Show resolved Hide resolved
demo/src/main/java/com/google/android/fhir/demo/data/DemoFhirSyncWorker.kt Outdated Show resolved Hide resolved
engine/src/main/java/com/google/android/fhir/sync/UploadWorkManager.kt Outdated Show resolved Hide resolved
engine/src/main/java/com/google/android/fhir/sync/UploadWorkManager.kt Outdated Show resolved Hide resolved
engine/src/main/java/com/google/android/fhir/sync/upload/UploaderImpl.kt Outdated Show resolved Hide resolved
jingtang10
jingtang10 approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anchita-g - happy for this to be merged but we might have some follow-ups to do.

engine/src/main/java/com/google/android/fhir/sync/UploadWorkManager.kt Show resolved Hide resolved
@anchita-g anchita-g mentioned this pull request Jul 28, 2023
Closed
@santosh-pingle santosh-pingle merged commit 65ddc7f into google:master Jul 31, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omarismail94 omarismail94 omarismail94 left review comments

@MJ1998 MJ1998 MJ1998 left review comments

@jingtang10 jingtang10 jingtang10 approved these changes

@santosh-pingle santosh-pingle Awaiting requested review from santosh-pingle

@aditya-07 aditya-07 Awaiting requested review from aditya-07 aditya-07 was automatically assigned from google/android-fhir

Assignees
No one assigned
Labels
None yet
Projects
Android FHIR SDK
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interface to control over what should be uploaded and how?
6 participants
@anchita-g @MJ1998 @jingtang10 @omarismail94 @santosh-pingle @android-fhir-bot