Add MSVC ARM64 support to cmake #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
LebedevRI
pushed a commit
that referenced
this pull request
Feb 12, 2021
Lacks CMake support, see #1090
|
I think this is good (sorry for the huge delay) but i have no obvious way to test it. @janisozaur, or someone else, can you confirm it's been tested and works? :) |
|
Yes, it was tested in the original PR #1052 and the results are still available. I did use the compiled library to build OpenRCT2 and run its benchmarks. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #1052, adds workaround for cmake when targeting ARM64 with MSVC