Add tests for Human Readable functionality #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fix an issue where the SI/IEC unit wasn't being correctly passed through.
dmah42
force-pushed
the
add_string_util_tests
branch
from
b2cc7ad
to
301ab76
Compare
| void AppendHumanReadable(int n, std::string* str) { | ||
| std::stringstream ss; | ||
| // Round down to the nearest SI prefix. | ||
| ss << ToBinaryStringFullySpecified(n, 0); |
There was a problem hiding this comment.
Just a question. Why are we not sending Counter::kIs1000? Or will we make this change afterwards?
There was a problem hiding this comment.
i wanted to get the barest minimal fixes for what's currently in the code before changing behaviour (aside from bug fixes).
LebedevRI
reviewed
Jul 14, 2023
LebedevRI
reviewed
Jul 14, 2023
| @@ -43,8 +43,8 @@ void ToExponentAndMantissa(double val, double thresh, int precision, | |||
| // Adjust threshold so that it never excludes things which can't be rendered | |||
| // in 'precision' digits. | |||
| const double adjusted_threshold = | |||
| std::max(thresh, 1.0 / std::pow(10.0, precision)); | |||
| const double big_threshold = adjusted_threshold * one_k; | |||
| std::max(1.0, 1.0 / std::pow(10.0, precision)); | |||
There was a problem hiding this comment.
Personally, i like that thresh goes away.
LebedevRI
previously approved these changes
Jul 14, 2023
LebedevRI
approved these changes
Jul 14, 2023
varshneydevansh
added a commit
to varshneydevansh/benchmark
that referenced
this pull request
Jul 14, 2023
…nto inconsistent_suffixes_console_reporter_1009 (from- google#1632)
varshneydevansh
added a commit
to varshneydevansh/benchmark
that referenced
this pull request
Jul 14, 2023
varshneydevansh
added a commit
to varshneydevansh/benchmark
that referenced
this pull request
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fix an issue where the SI/IEC unit wasn't being correctly passed through.