feat: benchmark_list_tests benchmark-format=json #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should not be added. My mistake
this file should not be added by me. test/ third_party / googletest / CMakeLists.txt
|
Now we have to add the test cases for this enhancement and also have to modify the console menu for this change. Line 729 in 1c64a36 and also the documentation =) or maybe we just need to modify the documentations and the test cases? |
dmah42
reviewed
Aug 14, 2023
dmah42
reviewed
Aug 14, 2023
dmah42
reviewed
Aug 14, 2023
| @@ -164,6 +164,14 @@ class TestReporter : public benchmark::BenchmarkReporter { | |||
| for (auto rep : reporters_) rep->Finalize(); | |||
| } | |||
|
|
|||
| void List(const std::vector<benchmark::internal::BenchmarkInstance>& | |||
There was a problem hiding this comment.
perhaps we could have a gtest for the List function?
|
Apologies, @dmah42 I am currently writing a book on ADHD and I didn't evaluate that it will take this much of time. I am trying to complete it soon and will work on the remaining issues. =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
clang-formatThe details
Resolves
Proposed Changes
To output the benchmark list in JSON format.
Behavior Before Change
Unable to get the desired output for the automation purpose in the JSN format.
Behavior After Change
Added the support for the use of
--benchmark_list_teststogether with--benchmark-format=json.Reason for Changes
With this change, the user will be able to get the benchmark output easily in JSON format for better machine use cases.
Test Coverage
I haven't tested this, as soon as I got confirmation that these are the required changes that will update the status of the Test Coverage.
Documentation
Documentation needs to be done for this as it's a feature request once this will pass all the test cases I will add the required document for this.
Additional Information