Avoid using CMake 3.6 feature list(FILTER ...) #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LebedevRI
reviewed
Jun 5, 2018
src/CMakeLists.txt
Outdated
| @@ -11,7 +11,7 @@ file(GLOB | |||
| *.cc | |||
| ${PROJECT_SOURCE_DIR}/include/benchmark/*.h | |||
| ${CMAKE_CURRENT_SOURCE_DIR}/*.h) | |||
| list(FILTER SOURCE_FILES EXCLUDE REGEX "benchmark_main\\.cc") | |||
| list(REMOVE_ITEM SOURCE_FILES "benchmark_main.cc") | |||
There was a problem hiding this comment.
Does that actually work though?
GLOB should result in absolute filenames..
There was a problem hiding this comment.
Right, fix coming
list(FILTER ...) is a CMake 3.6 feature, but benchmark targets CMake 2.8.12
Maratyszcza
force-pushed
the
fix-cmake-3.5-build
branch
from
a3ad8d0
to
89f67d5
Compare
|
✅ Build benchmark 1276 completed (commit 3aaaa4bc9a by @Maratyszcza) |
|
✅ Build benchmark 1277 completed (commit 45c457ac62 by @Maratyszcza) |
|
thanks for the quick fix. |
JBakamovic
pushed a commit
to JBakamovic/benchmark
that referenced
this pull request
Dec 6, 2018
list(FILTER ...) is a CMake 3.6 feature, but benchmark targets CMake 2.8.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
list(FILTER ...)is a CMake 3.6 feature, but benchmark targets CMake 2.8.12