Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible loss of data warnings in MSVC #694

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Conversation

pwnall
Copy link
Member

@pwnall pwnall commented Sep 30, 2018

Warning texts:
benchmark.h(558): warning C4244: 'argument': conversion from 'int64_t' to 'double', possible loss of data
benchmark.h(564): warning C4244: 'return': conversion from 'const double' to 'int64_t', possible loss of data
benchmark.h(587): warning C4244: 'argument': conversion from 'int64_t' to 'double', possible loss of data
benchmark.h(593): warning C4244: 'return': conversion from 'const double' to 'int64_t', possible loss of data

Thank you very much for maintaining google benchmark!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 89.053% when pulling 73ca0c6 on pwnall:msvc-warn into edc77a3 on google:master.

@AppVeyorBot
Copy link

Build benchmark 1502 completed (commit 725183bc2d by @pwnall)

@dmah42
Copy link
Member

dmah42 commented Oct 1, 2018

Thank you!

@dmah42 dmah42 merged commit d8c0f27 into google:master Oct 1, 2018
@pwnall
Copy link
Member Author

pwnall commented Oct 1, 2018

Thank you very much for the quick review!

@pwnall pwnall deleted the msvc-warn branch October 1, 2018 14:42
@LebedevRI
Copy link
Collaborator

Maybe in 2.0 we could change the signatures of those functions to avoid casts.

JBakamovic pushed a commit to JBakamovic/benchmark that referenced this pull request Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants