Cmake edit with 'make install' target #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
before i can merge this: have you signed a Google CLA? https://developers.google.com/open-source/cla/individual |
|
Done ;) |
|
should 'make install' not also copy the headers from include/ to /usr/local/include (on linux)? |
|
of course.. let me fix this.. |
|
ok done, sorry. |
| COMPONENT library) | ||
| INSTALL( | ||
| DIRECTORY "${PROJECT_SOURCE_DIR}/include/benchmark" | ||
| DESTINATION include |
There was a problem hiding this comment.
how do you feel about installing from include/ to include/ so they'll end up in /usr/local/include/benchmark/... ?
There was a problem hiding this comment.
Actually, everything ends up in include/benchmark/
%%%%> make install
[ 85%] Built target benchmark
[100%] Built target benchmark_test
Install the project...
-- Install configuration: ""
-- Installing: /usr/local/lib/libbenchmark.a
-- Installing: /usr/local/include/benchmark
-- Up-to-date: /usr/local/include/benchmark/benchmark.h
-- Up-to-date: /usr/local/include/benchmark/macros.h
dmah42
pushed a commit
that referenced
this pull request
Feb 6, 2014
Cmake edit with 'make install' target
This was referenced Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor pull request to enhance cmake build system: