Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ImGui on Android. #119

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Enable ImGui on Android. #119

merged 1 commit into from
Apr 24, 2023

Conversation

hysw
Copy link
Collaborator

@hysw hysw commented Apr 20, 2023

ImGui renders, but the aspect ratio is wrong.
We should get the Android Window size instead of hard code 720p.

ImGui renders, but the aspect ratio is wrong.
We should get the Android Window size instead of hard code 720p.
@hysw hysw requested a review from Keenuts April 20, 2023 19:34
@Keenuts Keenuts requested a review from apazylbe April 21, 2023 10:44
@apazylbe
Copy link
Collaborator

Is this enough to close #77? If that's the case, could you add Fixes https://github.com/google/bigwheels/issues/77 in the description (https://github.com/google/bigwheels/blob/main/CONTRIBUTING.md#for-developers-contributing-a-patch)

@hysw
Copy link
Collaborator Author

hysw commented Apr 21, 2023

Is this enough to close #77?

Not yet, this only enable the rendering of ImGui, there's at least a few more things to fix:

  • The surface size is wrong, so ImGui has a weird aspect ratio
  • Still need to add input support
  • The bigwheels Android event loop is broken (it's not processing Android input at all)

@apazylbe apazylbe merged commit defaa8a into google:main Apr 24, 2023
@apazylbe
Copy link
Collaborator

Thanks! I created 2 issues and assigned one existing to you, hope that's okay. If you are not planning to work on them, maybe you could add any relevant details and unassign?
Input handling: #78
Wrong surface size: #125
Event loop: #126

@hysw
Copy link
Collaborator Author

hysw commented Apr 24, 2023

Okay, I'm actually have all three fixed on my local branch, so sounds more than reasonable to me (a earlier sample here: c2e4881 )

@hysw hysw mentioned this pull request May 1, 2023
@hysw hysw deleted the tianc-imgui-android branch May 4, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants