Use system deps for protobuf, capstone and re2 #155
Conversation
Also, add option to disable setting build id for systems where this flag is not supported by ld and an option to disable installing cmake target files in case they aren't needed.
|
Forgot to mention, this is similar in spirit to #152 but a bit of a different approach. Also, I suppose finding the system deps via non-pkg-config methods would be a good idea, but I haven't done that yet. FWIW, I think supporting using these from the system makes sense since re2, capstone and protobuf are pretty widely packaged in various Linux distributions: https://repology.org/metapackage/re2/versions I think having this change will make it easier to package bloaty, which isn't as widely packaged yet: https://repology.org/metapackage/bloaty/versions Also, it might be good to add another ci target which has these deps installed and tests with them. I can do that as part of this pull request if you like, but wanted to get feedback first. |
|
Sorry for the slow reply. I think this is great. We can refine this over time (with more tests, searching methods, etc). but this seems like a good start. |
Note that with this system deps are used if they are found. I could add an option to only use them if requested or disabling using them if found if you like.
Also:
I could make these separate pull requests if you like.